Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Remove the shared code from BlockVolume.create ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File vdsm/storage/blockVolume.py Line 162: os.unlink(volPath) Don't we have a safe unlink method in fileutils? If we don't this could be a really good implementation for one
Line 169: cls.log.info("volUUID %s srcImg %s srvVol %s", volUUID, srcImgUUID, What are you logging exactly? The message doesn't really message anything
Line 200: # Return the metaId Don't comment what you do. Also if you think it's necessary to express put it in a var named metaId
-- To view, visit http://gerrit.ovirt.org/3628 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4e6b97c36b17f63773013e7d2eed2a57a600bedb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com