Nir Soffer has posted comments on this change.
Change subject: spbackends: do not set spmRole on forceFreeSpm
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27318/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Setting the spmRole to SPM_FREE on forceFreeSpm is harmful. In fact the
Line 10: release of the spm role (SPM_ACQUIRED) should go through the stopSpm
Line 11: procedure where the master filesystem is unmounted, etc.
Line 12:
Can you elaborate here on when this harmful code was added and why? Just to be confident
about this change.
Line 13: Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec
--
To view, visit
http://gerrit.ovirt.org/27318
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes