Ala Hino has posted comments on this change.
Change subject: virt: enable libgfapi ......................................................................
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/44061/6//COMMIT_MSG Commit Message:
Line 4: Commit: Ala Hino ahino@redhat.com Line 5: CommitDate: 2015-07-29 17:03:43 +0300 Line 6: Line 7: virt: enable libgfapi Line 8:
Please add a real commit message, see my comment in one of the older versio
Done Line 9: This change is based on Federico's changes: Line 10: https://gerrit.ovirt.org/33768/ Line 11: Line 12: Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
https://gerrit.ovirt.org/#/c/44061/6/vdsm/clientIF.py File vdsm/clientIF.py:
Line 313 Line 314 Line 315 Line 316 Line 317
Lets move this to the else: part of the disk type == network check.
Done
Line 320: drive['volumeChain'] = res['imgVolumesInfo'] Line 321: drive['volumeInfo'] = res['info'] Line 322: if drive.get('diskType') == DISK_TYPE.NETWORK: Line 323: volinfo = res ['info'] Line 324: volPath = volinfo['path']
We are overriding what we did in line 318 - better set this explicitly:
Done Line 325: drive['protocol'] = volinfo['protocol'] Line 326: # currently, single host is provided due to this bug: Line 327: # https://bugzilla.redhat.com/1247521 Line 328: drive['hosts'] = [volinfo['hosts'][0]]
https://gerrit.ovirt.org/#/c/44061/6/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py:
Line 57: for brick in volInfo[volname]['bricks']] Line 58: Line 59: return {'path': glusterPath, Line 60: 'protocol': 'gluster', Line 61: 'volfileServer': volfileServer,
any reason to keep this? see my comment in the previous version.
this is used in _disksnapshot method in vm.py