Change in vdsm[master]: storage: validateDirAccess: move to sdperm
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: validateDirAccess: move to sdperm
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73115/2/lib/vdsm/storage/sdperm.py
File lib/vdsm/storage/sdperm.py:
Line 28: from . import exception as se
Line 29: from . import outOfProcess
Line 30:
Line 31:
Line 32: def validate_dir_access(path):
Are you sure about accessing fileutils via oop? I think we are using
only i
Let me be more precise. in fileSD, we usually have
self.oop.fileUtils.someFunction()
fileUtils itself is unaware of our fancy implementation of IO operations.
The function that I am moving now is very different in this regard.
it is not clear to me what https://gerrit.ovirt.org/#/c/73094/5/lib/vdsm/storage/utils.py
aims to become. What is its difference relative to fileUtils?
It seems that it is similar in nature to fileUtils, in the sense that its user is obliged
to use an oop mechanism if he is accessing an NFS domain. If I am correct, then we have
the same issue as with fileUtils.
Line 33: """verify that path's permissions match those of a file
storage domain"""
Line 34: try:
Line 35: outOfProcess.getGlobalProcPool().fileUtils.validateAccess(path)
Line 36: supervdsm.getProxy().validateAccess(
--
To view, visit https://gerrit.ovirt.org/73115
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21ead1cb635f8224cb09f7319ffcb55eebe2a9e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes