Yoav Kleinberger has posted comments on this change.
Change subject: volume: support multi line metadata values
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28493/3/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 833: key, value = l.split("=")
Line 834: value = [value]
Line 835:
Line 836: put(key, value)
Line 837: return out
This is too complex.
agree with Nir on this.
Line 838:
Line 839: def metadata2info(self, meta):
Line 840: return {
Line 841: "uuid": self.volUUID,
--
To view, visit
http://gerrit.ovirt.org/28493
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib03152b852294f7b69a8734c2aa1206ea2c1fabe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes