Dan Kenigsberg has posted comments on this change.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/protect/spmprotect.sh Line 77: log "Trying to stop vdsm for spUUID=$spUUID id=$ID lease_path=$LEASE_FILE" maybe it is only because I wrote the lines you are deleting, but why is this change related to 752470 ?
-- To view, visit http://gerrit.ovirt.org/265 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com