Liron Aravot has posted comments on this change.
Change subject: hsm: prepareForShutdown - operations order ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36162/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3432 Line 3433 Line 3434 Line 3435 Line 3436
I think that it will be more correct to move
i agree, as of today self.taskMng.prepareForShutdown() already access the shared storage after releaseLocks - but it doesn't access the tasks dir (which it will after this change). Moving self.taskMng.prepareForShutdown() to be before self.__releaseLocks() may be trickier in terms of verification imo - but let's here other opinions on that.