Dan Kenigsberg has posted comments on this change.
Change subject: Bond destroying ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/netconf/ifcfg.py Line 468: Line 469: def removeBonding(self, bonding): Line 470: self._backup(netinfo.NET_CONF_PREF + bonding) Line 471: self._removeFile(netinfo.NET_CONF_PREF + bonding) Line 472: if bonding not in ['bond0', 'bond1', 'bond2', 'bond3', 'bond4']: right. and a frozenset() could have been even nicer.
But please look at lib/vdsm/tool/load_needed_modules.py.in
it has the same set of bonds, with the same meaning. It might be a good idea to define it in netinfo once, and use it from both places. Line 473: with open(netinfo.BONDING_MASTERS, 'w') as f: Line 474: f.write("-%s\n" % bonding) Line 475: Line 476: def removeBridge(self, bridge):
-- To view, visit http://gerrit.ovirt.org/13752 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0cd27f1ff9a62e202c3513e54df5481d1b72ed7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek psebek@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Petr Šebek psebek@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com