Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 705:
Line 706: self._devices = XMLElement('devices')
Line 707: self.dom.appendChild(self._devices)
Line 708:
Line 709: def _isHyperV(self):
well, I'd prefer not to spread arch checks like plague and try to
trust eng
Will drop the architecture check and the helper method.
Line 710: return (self.arch == caps.Architecture.X86_64 and
Line 711: utils.tobool(self.conf.get('hypervEnable',
'false')))
Line 712:
Line 713: def appendClock(self):
--
To view, visit
http://gerrit.ovirt.org/27619
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes