Allon Mureinik has posted comments on this change.
Change subject: block: add blkdiscard on zero image
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/35631/3/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 228: try:
Line 229: utillinux.blkdiscard(path)
Line 230: except utillinux.BlkDiscardError as e:
Line 231: # At the moment this operation is best-effort
Line 232: log.info('ignoring block discard error: %s', e)
I wonder if we'd like to add some info on the return value, so this can be propagated
to the engine
Line 233:
Line 234: deleteVolumes(sdUUID, volUUID)
Line 235: log.debug('zeroing of volume %s on domain %s for task %s '
Line 236: 'completed successfully', volUUID, sdUUID, taskid)
http://gerrit.ovirt.org/#/c/35631/3/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 227: try:
Line 228: utillinux.blkdiscard(path)
Line 229: except utillinux.BlkDiscardError as e:
Line 230: # At the moment this operation is best-effort
Line 231: log.info('ignoring block discard error: %s', e)
same comment here.
Line 232: finally:
Line 233: self.teardown(self.sdUUID, self.volUUID, justme=True)
Line 234:
Line 235: # try to cleanup as much as possible
--
To view, visit
http://gerrit.ovirt.org/35631
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e059c556c550440727b36b8af8e5dfc29ce2ccb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes