Ayal Baron has posted comments on this change.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
Patch Set 7:
(3 comments)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 310:
Line 311: def validateSPM(self, spUUID):
Line 312: pool = self.getPool(spUUID)
Line 313: if pool.spmRole != sp.SPM_ACQUIRED:
Line 314: lvm.setLvmROMD()
redundant
Line 315: raise se.SpmStatusError(spUUID)
Line 316:
Line 317: def validateNotSPM(self, spUUID):
Line 318: pool = self.getPool(spUUID)
Line 601: :raises: :exc:`storage_exception.TaskInProgress`
Line 602: if there are tasks running for this pool.
Line 603:
Line 604: """
Line 605: lvm.setLvmROMD()
should be in stopSpm inside sp
Line 606: vars.task.setDefaultException(se.SpmStopError(spUUID))
Line 607: vars.task.getExclusiveLock(STORAGE, spUUID)
Line 608:
Line 609: pool = self.getPool(spUUID)
http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 267:
Line 268: try:
Line 269: self.lver = int(oldlver) + 1
Line 270:
Line 271: blockSD.lvm.setLvmRWMD() # Do it later
1. do it later where? why?
Line 272:
Line 273: self._backend.setSpmStatus(self.lver, self.id,
Line 274: __securityOverride=True)
Line 275: self._maxHostID = maxHostID
--
To view, visit
http://gerrit.ovirt.org/2218
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <haim.ateya(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes