Alon Bar-Lev has posted comments on this change.
Change subject: storage: set block schedule elevator using udev ......................................................................
Patch Set 1:
Hello,
We change the default, just using udev to do that.
User can still use EXISTING udev rule or cronjob to override the setting, nothing was changed!
Yes, writing udev is priority based, whoever writes such a rule needs to be aware of the ordering. If this *REALLY* bothers you and you think people that uses udev do not know what they are doing we can put our rule at level 00, so it runs first.
However, I do believe people know what they are doing, and we can count these people who overridden scheduler on one hand.
Anyway is better than placing this udev rule in bootstrap anyway. So I find the suggested solution to be just fine.
Alon
-- To view, visit http://gerrit.ovirt.org/8700 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0a8de1c861bf4570509599b6f47235ed38cc424d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Fabian Deutsch fabiand@fedoraproject.org Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com