Dan Kenigsberg has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
But I do like the idea, please push it through.
.................................................... Commit Message Line 10: * remove /data/updates after vdsm rpm uninstalled The most interesting thing to put in a commit message is the WHY. The motivation is not self-evident, even though I can think of two:
1. vdsmd.init is too complex
2. /data/updates is relevant only to vdsm-reg and ovirt-node, not vdsm proper.
.................................................... File vdsm_reg/vdsm-reg-setup.in Line 234: upgradeDir = os.path.dirname(config.get('vars', trailing redspace
Line 237: if not os.path.exists(upgradeDir): this code was in a separate (bash) function. the containing run() function is too long as it is. so let's keep in its own (python) function.
.................................................... File vdsm_reg/vdsm-upgrade Line 17: from config import config this change of how "config" is read, is not really related, let's review it separately, in its own patch.
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com