Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: add gateway reporting to all devices
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/28704/9/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 733: try:
Line 734: gateway, = gateways
Line 735: except ValueError:
Line 736: if len(gateways) > 1:
Line 737: logging.debug('Multiple default gateways in table: %s',
table)
debug? I find it as an improbable ERROR, and I'd log gateways, too.
Line 738: return '::' if family == 6 else ''
Line 739: return gateway['gateway']
Line 740:
Line 741:
--
To view, visit
http://gerrit.ovirt.org/28704
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dc4730214efa9eaba8425c3bf4842441b97084f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes