Change in vdsm[master]: lvm: Fail loudly if called with unexpected input

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: lvm: Fail loudly if called with unexpected input
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37329/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 731: 
Line 732:     if force is True:
Line 733:         options = ("-y", "-ff")
Line 734:         _initpvs_removeHolders()
Line 735:     else:
how about adding it after an

 elif force is False:

?
Line 736:         options = tuple()
Line 737: 
Line 738:     rc, out, err = _createpv(devices, metadataSize, options)
Line 739:     _lvminfo._invalidatepvs(devices)


-- 
To view, visit http://gerrit.ovirt.org/37329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9e6754d4aa2efaf894a9309cfaa4595d710063b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes