Ayal Baron has posted comments on this change.
Change subject: setVmTicket: add before and after hooks ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File vdsm_cli/vdsClient.py Line 311: params = {'userName': userName, 'userId': userId} should be generic. First 4 (mandatory) params should be passed by name, the rest should be just pushed into a dict. vmId, otp64, secs, connAct = args[:4] params = args[4:] (probably just a string like backend passes? or need to convert into a dict or something) ...
Line 1625: ('<vmId> <password> <sec> [disconnect|keep|fail]', no mention of optional 'params'?
.................................................... File vdsm/libvirtvm.py Line 1925: userName = params.get('userName', '') why do we expose the specific params here? It should be up to the script to determine what it needs ?!?
-- To view, visit http://gerrit.ovirt.org/3565 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I48cbc934e48055630b734a2d3c79c72b6c36f28f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com