Dan Kenigsberg has posted comments on this change.
Change subject: Reduce the number of getVolumeSize() calls. ......................................................................
Patch Set 9: Code-Review-1
(2 comments)
.................................................... File vdsm/storage/blockVolume.py Line 204: self.prepare(justme=True, rw=True, chainrw=force, setrw=True, Line 205: force=True) Line 206: try: Line 207: misc.ddWatchCopy( Line 208: "/dev/zero", vol_path, vars.task.aborting, int(zeroLen), int() is now redundant and misleading. Line 209: recoveryCallback=volume.baseAsyncTasksRollback) Line 210: except utils.ActionStopped: Line 211: raise Line 212: except Exception:
.................................................... File vdsm/storage/hsm.py Line 695: Line 696: if volFormat != volume.COW_FORMAT: Line 697: # This method is used only with COW volumes (see docstring), Line 698: # for RAW volumes we just return the volume size. Line 699: return dict(size=str(domain.getVSize(imgUUID, volUUID))) needs a rebase - this bug has been fixed by http://gerrit.ovirt.org/19279 Line 700: Line 701: qemuImgFormat = volume.fmt2str(volume.COW_FORMAT) Line 702: Line 703: volToExtend.prepare()