Assaf Muller has posted comments on this change.
Change subject: vdsm-tool: Change upgrade mechanism
......................................................................
Patch Set 1:
If you git blame and look at the patches that introduced the upgrade mechanism you'd
see that Saggi NACK'd inheritance, on the basis that inheritance should never be used
in Python (This is an oversimplification but was the basis for his argument). I disagreed
with him but implemented it without inheritance as he asked. Let's see if you can
convince him now :)
--
To view, visit
http://gerrit.ovirt.org/27193
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No