Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
good enough for me.
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Line 37:
Line 38: # we need it to satisfy pyflakes
Line 39: sslutils
Line 40: SSLHandshakeDispatcher
Line 41: SSLSocket
does pyflakes complain if you remove this...
Line 42:
Line 43: if _USED_IMPLEMENTATION is None:
Line 44: from . import sslutils
Line 45: from .sslutils import SSLHandshakeDispatcher
Line 47:
Line 48: # we need it to satisfy pyflakes
Line 49: sslutils
Line 50: SSLHandshakeDispatcher
Line 51: SSLSocket
...and deindent this?
--
To view, visit
https://gerrit.ovirt.org/44689
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Sandro Bonazzola
sbonazzo@redhat.com
Gerrit-Reviewer: Simone Tiraboschi
stirabos@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes