Change in vdsm[master]: vm: refresh all volumes after migration

Ayal Baron has posted comments on this change.

Change subject: vm: refresh all volumes after migration
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1637:     def refreshAllDrives(self):
Line 1638:         volInfoList = []
Line 1639: 
Line 1640:         for device in self._devices[vm.DISK_DEVICES][:]:
Line 1641:             if not device.blockDev or not hasattr(device, 'domainID'):
since this test is repeated in several places, please consider refactoring it into a method (other places are possibly currently missing the domainID check even though they should check for it)
Line 1642:                 continue
Line 1643: 
Line 1644:             volInfoList.append({
Line 1645:                 'domainID': device.domainID,

--
To view, visit http://gerrit.ovirt.org/8518
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe0bd784e68f162b7902bb6ae50ff183d9f8fa8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel P. Berrange