Adam Litke has posted comments on this change.
Change subject: [WIP] Start moving proc parsing to it's own module ......................................................................
Patch Set 1: (2 inline comments)
Just a couple of minor comments ... PLEASE improve your commit messages too!
.................................................... Commit Message Line 4: Commit: Saggi Mizrahi smizrahi@redhat.com Line 5: CommitDate: 2012-08-27 17:43:35 -0400 Line 6: Line 7: [WIP] Start moving proc parsing to it's own module Line 8: We really need to do a better job describing our patches. This is just not good enough. Line 9: Change-Id: I7ba84c7ece95bdef7448a7c7af277e7f58695401
.................................................... File vdsm/utils.py Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: """ Line 22: A module containing miscellaneous functions and classes that are user s/user/used/ Line 23: plentifuly around vdsm. Line 24: Line 25: .. attribute:: utils.symbolerror Line 26:
-- To view, visit http://gerrit.ovirt.org/7513 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ba84c7ece95bdef7448a7c7af277e7f58695401 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server