Dan Kenigsberg has posted comments on this change.
Change subject: periodic: add __str__ methods
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48193/7/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Line 314:
Line 315:
Line 316: class NumaInfoMonitor(_RunnableOnVm):
Line 317:
Line 318: NAME = "NumaInfoMonitor"
why are these any better than self.__class__.__name__ ?
Line 319:
Line 320: @property
Line 321: def required(self):
Line 322: return self._vm.hasGuestNumaNode
--
To view, visit
https://gerrit.ovirt.org/48193
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d1180b727571cce34e8304ac48390ed2135f79
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
mpolednik@redhat.com
Gerrit-Reviewer: Milan Zamazal
mzamazal@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes