Change in vdsm[master]: gluster:refactor: User specified backup servers option

Ala Hino has posted comments on this change.

Change subject: gluster:refactor: User specified backup servers option
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43003/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: gluster:refactor: User specified backup servers option
Line 8: 
Line 9: Move handling user specified backup servers option from
Line 10: _get_backup_servers_option method to options property.
>  can you explain why the suggested code is better than the original
> one? 
To address Nir's comment:
"
This check should be in options() - you should not access self._options in many places,
better access it only in options() and let other code access self.options.
"

Provided here:
https://gerrit.ovirt.org/#/c/41931/40/vdsm/storage/storageServer.py
Line 11: 
Line 12: Change-Id: I4238328cfe230852182a1d997bd51b00f686f4a8


-- 
To view, visit https://gerrit.ovirt.org/43003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4238328cfe230852182a1d997bd51b00f686f4a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes