Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Add selinux enforcement reporting. ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26951/1/vdsm/caps.py File vdsm/caps.py:
Line 390: else: Line 391: return platform.machine() Line 392: Line 393: Line 394: def getSELinuxEnforceMode(): What about have this function available in /usr/<lib>/python-2.7/site-packages/vdsm/utils.py ? IMO, can fit there, not limiting the availability in caps.py. Before doing that, please consult others. Line 395: selinux_mnts = ['/sys/fs/selinux', '/selinux'] Line 396: for mnt in selinux_mnts: Line 397: enforce_path = os.path.join(mnt, 'enforce') Line 398: if not os.path.exists(enforce_path):