Nir Soffer has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain ......................................................................
Patch Set 2:
(2 comments)
Commit message still need more love.
http://gerrit.ovirt.org/#/c/25424/2//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2014-03-05 15:25:56 +0200 Line 4: Commit: Liron Ar laravot@redhat.com Line 5: CommitDate: 2014-03-06 10:55:35 -0500 Line 6: Line 7: sp: fix spm start when failing to produce domain Tittle is still wrong - you explain bellow that this handle errors when altering domain role. Line 8: Line 9: During spmStart we attept to go over all the domains and set their role Line 10: to be regular in case it's not to avoid situation in which there are two Line 11: domains with the master role.
Line 5: CommitDate: 2014-03-06 10:55:35 -0500 Line 6: Line 7: sp: fix spm start when failing to produce domain Line 8: Line 9: During spmStart we attept to go over all the domains and set their role attept is still misspelled. Line 10: to be regular in case it's not to avoid situation in which there are two Line 11: domains with the master role. Line 12: If we fail to produce any of the domains (which might happen, the Line 13: domains returned by getDomains(activeOnly=True) are all the domains that