Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
......................................................................
Patch Set 1:
(2 comments)
....................................................
File client/vdsClient.py
Line 1694:
Line 1695: def startMonitoringDomain(self, args):
Line 1696: sdUUID, hostID = args
Line 1697: self.s.startMonitoringDomain(sdUUID, hostID)
Line 1698: return 0, ''
Always return 0? doesn't self.s.startMonitoringDomain(sdUUID, hostID) return the usual
dict with ['status']['code'] ?
Line 1699:
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)
Line 1698: return 0, ''
Line 1699:
Line 1700: def stopMonitoringDomain(self, args):
Line 1701: sdUUID, = args
Line 1702: self.s.stopMonitoringDomain(sdUUID)
same here
Line 1703: return 0, ''
Line 1704:
Line 1705: def snapshot(self, args):
Line 1706: vmUUID, sdUUID, imgUUID, baseVolUUID, volUUID = args
--
To view, visit
http://gerrit.ovirt.org/19762
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes