Dima Kuznetsov has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/42908/4/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 31: self._waiters = []
Line 32: self._readers = set()
Line 33: self._writer = None
Line 34:
Line 35: def acquireWrite(self):
Can we have pep8 method names?
Line 36: with self._lock:
Line 37: if self._writer or self._readers or self._waiters:
Line 38: self._wait(True)
Line 39: self._writer = threading.current_thread()
Line 73: self._lock.acquire()
Line 74: finally:
Line 75: self._waiters.remove(waiter)
Line 76:
Line 77: def _wakeup_waiter(self):
Does this wake up all queued readers after write unlock?
Line 78: if self._readers and self._waiters[0].wants_write:
Line 79: return
Line 80: self._waiters[0].wakeup()
Line 81:
--
To view, visit
https://gerrit.ovirt.org/42908
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes