From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Add confutil to manage properties files easily
......................................................................
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/44286/13/lib/vdsm/tool/confutils.py
File lib/vdsm/tool/confutils.py:
PS13, Line 66: if vdsmConfiguration:
Do we need this check? From the code it looks like we use is_applicable to
just moved the code in this patch. but I guess this here to avoid calling is_applicable if vdsmConfiguration is empty, in your suggestion I'll need to change also is_applicable to check for keyError exception
--
To view, visit
https://gerrit.ovirt.org/44286
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id67a0f51adb2d543c0542a48c020d34a13d1f2ed
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Irit Goihman
igoihman@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Peřina
mperina@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes