Darshan N has posted comments on this change.
Change subject: gluster: Add geo-replication start and stop session
......................................................................
Patch Set 7:
(6 comments)
http://gerrit.ovirt.org/#/c/17766/7//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2013-09-02 18:40:48 +0530
Line 4: Commit: ndarshan <dnarayan(a)redhat.com>
Line 5: CommitDate: 2014-11-18 18:30:45 +0530
Line 6:
Line 7: gluster: geo-replication start and stop session
Please say 'add geo-replication start and stop session'
Done
Line 8:
Line 9: This patch adds two new verbs to start and stop
Line 10: geo-replication session between master and slave
Line 11: volume. It returns a boolean output.
Line 7: gluster: geo-replication start and stop session
Line 8:
Line 9: This patch adds two new verbs to start and stop
Line 10: geo-replication session between master and slave
Line 11: volume. It returns a boolean output.
Please add more comments and replace master/slave to local/remote
Done
Line 12:
Line 13: Change-Id: I3cf03c748cf9fe28efe7d407727cd52da20701c5
Line 14: Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com>
http://gerrit.ovirt.org/#/c/17766/7/client/vdsClientGluster.py
File client/vdsClientGluster.py:
Line 767: '[force={yes|no}]\n\t'
Line 768: '<master_volume_name>existing volume name in the master
node\n\t'
Line 769: '<slave_host_name>is remote slave host name or
ip\n\t'
Line 770: '<slave_volume_name>existing volume name in the slave
node',
Line 771: 'start the geo-replication session'
Please fix master/slave to local/remote
Done
Line 772: )),
Line 773: 'glusterVolumeGeoRepStop': (
Line 774: serv.do_glusterVolumeGeoRepSessionStop,
Line 775: ('volumeName=<master_volume_name> '
Line 778: '[force={yes|no}]\n\t'
Line 779: '<master_volume_name>existing volume name in the master
node\n\t'
Line 780: '<slave_host_name>is remote slave host name or
ip\n\t'
Line 781: '<slave_volume_name>existing volume name in the slave
node',
Line 782: 'stop the geo-replication session'
same here
Done
Line 783: )),
http://gerrit.ovirt.org/#/c/17766/7/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:
Line 510:
Line 511: #geo-replication
Line 512: class GlusterGeoRepException(GlusterException):
Line 513: code = 4560
Line 514: message = "Gluster Geo-Replication Exception"
Why do we need this parent exception? If its unused, please remove
it
will be using this as parent exception for all geo-replication excwptions
Line 515:
Line 516:
Line 517: class GlusterVolumeGeoRepSessionStartFailedException(GlusterVolumeException):
Line 518: code = 4173
Line 520:
Line 521:
Line 522: class GlusterVolumeGeoRepSessionStopFailedException(GlusterVolumeException):
Line 523: code = 4174
Line 524: message = "Volume geo-replication stop failed"
Move above two exception to respective section.
Done
--
To view, visit
http://gerrit.ovirt.org/17766
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf03c748cf9fe28efe7d407727cd52da20701c5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes