Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit ......................................................................
Patch Set 3:
(1 comment)
.................................................... File lib/vdsm/utils.py Line 458: Line 459: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True, Line 460: printable=None, env=None, sync=True, nice=None, ioclass=None, Line 461: ioclassdata=None, setsid=False, execCmdLogger=logging.root, Line 462: killOnExit=False): Why do you think "death" is more thread-specific than "exit"? After all the pthread lib has pthread_exit not pthread_die. If you think that "death" is better because it both includes exits and, well, process deaths (crashes) then we could consider:
* killOnDeath * stopOnExit/stopOnDeath * terminateOnExit/terminateOnDeath
Anyway my point here is that "deathSignal" really looks confusing (let's leave it for BetterPopen where in fact we specify a signal to use). Line 463: """ Line 464: Executes an external command, optionally via sudo. Line 465: """ Line 466: if ioclass is not None: