Edward Haas has posted comments on this change.
Change subject: net: netinfo.dhcp - dhcp info update refactoring
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61457/1/lib/vdsm/network/netinfo/dhcp.py
File lib/vdsm/network/netinfo/dhcp.py:
PS1, Line 27: dev_info['dhcpv4'] = network_info['dhcpv4']
: dev_info['dhcpv6'] = network_info['dhcpv6']
shouldn't this be the other way around? network_info[...] =
dev_info[...]?
Nope, it is setting the net device dhcp data, copying it from the
already updated network data.
(same logic as the original)
--
To view, visit
https://gerrit.ovirt.org/61457
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd64d67f52ac30c97e0730035dbe35c9c4e3c098
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes