Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
......................................................................
Patch Set 7: Verified-1
(1 comment)
As in the comment I tested different combination of runtime and build settings and the code fails. Giving -1 for visibility.
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Line 35: else:
Line 36: _USED_IMPLEMENTATION = 'm2c'
Line 37:
Line 38: # we need it to satisfy pyflakes
Line 39: sslutils
When building with m2c and ssl and running it with ssl setting the code fails in line #39. Need to be fixed.
Line 40: SSLHandshakeDispatcher
Line 41: SSLSocket
Line 42:
Line 43: if _USED_IMPLEMENTATION is None:
--
To view, visit
https://gerrit.ovirt.org/44689
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Sandro Bonazzola
sbonazzo@redhat.com
Gerrit-Reviewer: Simone Tiraboschi
stirabos@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes