Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move path getters ......................................................................
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/41995/13/vdsm/storage/sd.py File vdsm/storage/sd.py:
Line 320: """ Line 321: return os.path.join(self.domaindir, DOMAIN_IMAGES, ISO_IMAGE_UUID) Line 322: Line 323: def getMDPath(self): Line 324: if self.domaindir:
Is this possible? I would like to eliminate the possible None return value.
sp.py checks for None and raises an exception. It must be needed for some reason. Anyway, changing this should be done as a separate patch. This refactoring series is not the appropriate place to make such a change. Line 325: return os.path.join(self.domaindir, DOMAIN_META_DATA) Line 326: return None Line 327: Line 328: