Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44061/7/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 316
Line 317
Line 318
Line 319
Line 320
You missed my comment on an older version - you cannot must use Drive.volumeInfo.
Drive.volumeInfo was replaced by Drive.diskType, path, protocol, hosts, auth.
The best would be to remove Drive.volumeInfo in a separate patch. See Drive.__slots__
--
To view, visit
https://gerrit.ovirt.org/44061
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
ahino@redhat.com
Gerrit-Reviewer: Ala Hino
ahino@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes