Dan Kenigsberg has posted comments on this change.
Change subject: PARTIAL: explicitly close libvirt connection after use
......................................................................
Patch Set 1:
Toni, I still do not get why explicitly setting conn.__enter__ is any better than
def get():
bla
conn = foo
return closing(conn)
(not that we can actually use either of these due to the refcount issue)
--
To view, visit
http://gerrit.ovirt.org/17192
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15f3ab017828a63960ba9311fa2bf6bfab4729
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server