Dan Kenigsberg has posted comments on this change.
Change subject: Use the fileUtils.chown during the network backup
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 37: from storage import fileUtils
hmm, configNetwork should be storage-ignorant.
I remember we had an issue with importing storage too early:
vdsm/utils.py-599-def execCmd(*args, **kwargs):
vdsm/utils.py-600- # import only after config as been initialized
vdsm/utils.py:601: from storage.misc import execCmd
vdsm/utils.py-602- return execCmd(*args, **kwargs)
please double-check this issue
--
To view, visit
http://gerrit.ovirt.org/387
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>