Dan Kenigsberg has posted comments on this change.
Change subject: utils: atomic file write
......................................................................
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py
File lib/vdsm/utils.py:
PS9, Line 936: file
this is a builtin type, better use "filename"
PS9, Line 942: b
bb
PS9, Line 957: copyfile
copyfile is NOT atomic. you must use os.rename() which is promised by POSIX to either success or fail, never to partially write something on destination.
--
To view, visit
https://gerrit.ovirt.org/61482
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes