Dan Kenigsberg has posted comments on this change.
Change subject: nfs-check: check if temp dir exists ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File contrib/nfs-check.py Line 29: TMPDIR = "/tmp" evil tab
Line 249: tempfile.tempdir = TMPDIR why do you force the user to use /tmp? maybe his $TEMPDIR is /var/tmp, why should you care?
Line 254: LOCALPATH = tempfile.mkdtemp() I suppose it would be safe to solve the issue by reporting a clear exception here (if indeed this operation failed)
-- To view, visit http://gerrit.ovirt.org/3167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com