Timothy Asir has posted comments on this change.
Change subject: Added gluster volume top functionalities
......................................................................
Patch Set 9: No score
(2 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-09-06 19:33:25 +0530
Line 4: Commit: Timothy Asir <tjeyasin(a)redhat.com>
Line 5: CommitDate: 2012-12-05 18:00:21 +0530
Line 6:
Line 7: Added gluster volume top functionalities
Done
Line 8:
Line 9: new verb: glusterVolumeTopOpen
Line 10: output structure:
Line 11: When nfs is False:
....................................................
File vdsm/gluster/cli.py
Line 947: raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
Line 948:
Line 949:
Line 950: @exportToSuperVdsm
Line 951: def volumeTopOpen(volumeName, brickName=None, nfs=False, listCount=0):
If volume name only given, it provides output for all bricks (in this case, brickName=None
refers all bricks when nfs is false)
if volume name and a specific brick name is given, it provides output for the specific
brick
if volume name and nfs is given, it provides output for nfs only
and if volume name, brick name and nfs is given, the command execution will fail and throw
an usage error.
is it good idea to have a two verbs; one is for brick and volume and another is for volume
and nfs?
Line 952: """
Line 953: Returns:
Line 954: When nfs=True:
Line 955: [{'nfs': SERVER-NAME,
--
To view, visit
http://gerrit.ovirt.org/7844
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96486363a9acb7472014a67fcd2d5185d4f3c428
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server