Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
......................................................................
Patch Set 13: Verified+1
(1 comment)
Passed utilsTests.py
https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 953: if os.path.exists(filename):
Line 954: shutil.copyfile(filename, tmp_filename)
Line 955: with open(tmp_filename, flag) as f:
Line 956: yield f
Line 957: except IOError:
still too generic. isn't IOException enough here?
Changed to IOError.
Line 958: rmFile(tmp_filename)
Line 959: raise
Line 960: else:
--
To view, visit
https://gerrit.ovirt.org/61482
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
mpolednik@redhat.com
Gerrit-Reviewer: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes