Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write ......................................................................
Patch Set 14: Verified+1
(1 comment)
Passed utilsTests.py
https://gerrit.ovirt.org/#/c/61482/13/tests/utilsTests.py File tests/utilsTests.py:
Line 1060: fcntl.fcntl(hisPipe, fcntl.F_SETFL, os.O_NONBLOCK) Line 1061: fcntl.fcntl(myPipe, fcntl.F_SETFL, os.O_NONBLOCK) Line 1062: proc = Process(target=_raiseEAGAIN, args=(hisPipe,)) Line 1063: proc.start() Line 1064: self._noIntrWatchFd(myPipe, isEpoll=False, mask=select.POLLIN)
Please add a test with an exception and check that the temp file is cleaned
Done Line 1065: proc.join() Line 1066: Line 1067: Line 1068: class AtomicFileWriteTest(TestCaseBase):