Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsmd.init.in adapt to both Fedora and Ubuntu ......................................................................
Patch Set 2:
Thanks Dan. I agree that the init file is huge. When I read the code, the complexity comes from the actual work it does. (1) In systemd we can define conflicting and dependency service, but sysv init file lacks this ability. So we implement these functions in the init script. (2) It detects and modifies libvirt conf files. (3) Many trivial but necessary works like mk_data_center, mk_core_path, mk_dom_backup, /bin/chmod 1777 /dev/shm...
I think we can improve the situation for (1) by implementing some of the service management utility functions in VDSM-tools in a portable way. Improve (2) by using augtool. For (3), we are already doing the best. I think it's better to keep those trivial but necessary things in one place and manage them together. After these optimizations, the size of the init script may be halved.
I once tried to break it and found there would be much testing work to prove we do it right, and might introduce ugly bugs. Now I'm glad we all agree to break it.
-- To view, visit http://gerrit.ovirt.org/13489 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I186743ed7fd345bf150047d4005818e1df3c07fc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server