Adam Litke has posted comments on this change.
Change subject: storage: Introduce VolumeManifest.operation context ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64362/2/tests/storage_volume_test.py File tests/storage_volume_test.py:
Line 116: self.assertEqual(2, vol.setMetadata.nr_calls) Line 117: Line 118: def test_operation_fail_inside_context(self): Line 119: img_id = str(uuid.uuid4()) Line 120: vol_id = str(uuid.uuid4())
I think its time to introduce a helper to create uuid string without repeat
Done Line 121: Line 122: with fake_env('file') as env: Line 123: env.make_volume(MB, img_id, vol_id) Line 124: vol = env.sd_manifest.produceVolume(img_id, vol_id)