Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
nice, thanks, few inline comments for clarity. Partial ACK.
https://gerrit.ovirt.org/#/c/64272/2/tests/v2vTests.py File tests/v2vTests.py:
PS2, Line 130: file is this correct for the test you added? It seems to me that this works by accident
Line 534: ProtectedPassword('password'), Line 535: None)['vmList'] Line 536: Line 537: self.assertEqual(len(vms), len(VM_SPECS)) Line 538: self.assertTrue('mapper' in vms[0]['disks'][0]['alias']) This is a bit clearer, IMO:
self.assertEqual('/dev/mapper/vdev', vms[0]['disks'][0]['alias'])
but it's untested, could be broken; also, please consider making '/dev/mapper/vdev' a constant. Line 539: Line 540: def testXenBlockDevice(self): Line 541: def _connect(uri, username, passwd): Line 542: self._vms[0].setDiskType('block')