Change in vdsm[master]: vdsm-logrotate.conf: Add copytruncate

Mark Wu has posted comments on this change.

Change subject: vdsm-logrotate.conf: Add copytruncate
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/vdsm-logrotate.conf.in
Line 1: /var/log/vdsm/*.log {
Line 2:     rotate 100
Line 3:     copytruncate
Zhengsheng,
Thanks for taking time to look into this problem. As you said, the file logging handler in libvirt can't detect the file change. So it will still keep the original log open, which make the disk space can't be freed when logrotate removes it.  I didn't notice that the lograte's configuration will impact on other logs except vdsm.  That's my fault.  I apologize for that. 
But I can't explain why vdsm.log.1 was still kept open. It's expected to be closed by WatchedFileHandler.

Anyway, copytruncate is necessary for libvirt and no harm with WatchedFileHandler.
Line 4:     missingok
Line 5:     size 15M
Line 6:     compress
Line 7:     compresscmd /usr/bin/xz

--
To view, visit http://gerrit.ovirt.org/13499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie018b2039eac565cfdb5874c664b177d6fad64fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server