Ayal Baron has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
......................................................................
Patch Set 19:
Dan, as Nir noted and I tried to explain previously, your race does not exist.
It is very simple:
devices are added, getDevicesVisibility is used to discover newly added devices, this must update the list of devices used in commands. period. regardless of anything else.
The patch does exactly what it is supposed to do.
If you forget monitoring and focus on the simple fact that
with the spm architecture you always have a period of time between spm making changes and other hosts being aware of these changes then you realize why we have the fallback in case of error (i.e. if failed - bypass caches and refresh).
--
To view, visit
http://gerrit.ovirt.org/20552
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov
pzhukov@redhat.com
Gerrit-Reviewer: Ayal Baron
abaron@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Eduardo
ewarszaw@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Lee Yarwood
lyarwood@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Pavel Zhukov
pzhukov@redhat.com
Gerrit-Reviewer: Saggi Mizrahi
smizrahi@redhat.com
Gerrit-Reviewer: Sergey Gotliv
sgotliv@redhat.com
Gerrit-Reviewer: Tomáš Došek
tdosek@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-HasComments: No