Dan Kenigsberg has posted comments on this change.
Change subject: Skip monitoring the usage of tmpfs filesystems in diskStats ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/sampling.py Line 160: for p in self.MONITORED_PATHS: Line 161: rc, out, _ = utils.execCmd(['stat', '--file-system', '--format=%T', Line 162: p]) Line 163: if rc == 0 and out[0] == 'tmpfs': Line 164: continue If we have to filter out the tmpfs-mounted paths, how about doing this with storage.mount.mount? I'd prefer to have a path->vfstype mapping function there.
But in a more general note - if we do not need to monitor these paths on Fedora 18-based nodes, we most probably do not need to monitor them AT all. I do think that we SHOULD monitor them, but lower the threshold on Engine. Line 165: Line 166: free = 0 Line 167: try: Line 168: stat = os.statvfs(p)