Change in vdsm[master]: make vdsmd.init.in adapt to both Fedora and Ubuntu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: make vdsmd.init.in adapt to both Fedora and Ubuntu
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Your changes seem fine, but they only add to the monstrosity that is vdsmd.init.

Can we be more brutal, and break vdsmd.init apart? No other sysv service is that huge, and not other upstart service use such a horrible script.

....................................................
File vdsm/vdsmd.init.in
Line 248: 
Line 249:     # Remove configuration created by vdsm (old "# by vdsm" and the new format)
Line 250:     # Argument: configuration file that will be inspected
Line 251:     remove_vdsm_conf() {
Line 252:         sed -i -e "/${start_conf_section}/,/${end_conf_section}/d" \
this --copy is (used to be?) important for ovirt-node.
Line 253:             -e "/$by_vdsm/d" "$@"
Line 254:     }
Line 255: 
Line 256:     set_if_default() {

--
To view, visit http://gerrit.ovirt.org/13489
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I186743ed7fd345bf150047d4005818e1df3c07fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server