Dan Kenigsberg has posted comments on this change.
Change subject: py3: fix remaining references to monitor.MonitorError as iterable ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64929/1/init/wait_for_ipv4s File init/wait_for_ipv4s:
Line 50: ipless_devs.remove(dev_name) Line 51: if not ipless_devs: Line 52: return Line 53: except monitor.MonitorError as e: Line 54: if e.args[0] == monitor.E_TIMEOUT:
Possibly nitpicking, but perhaps adding some property to MonitorError (a la
You are probably right, though I don't know if 'reason' fits a simple code or 'errno' (but errno is misleading). Line 55: sys.stderr.write('IP addresses has not been caught within the ' Line 56: 'given timeout.\n') Line 57: else: Line 58: raise