Peter V. Saveliev has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 11: (3 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 327: def vmDesktopSendHcCommand(self, vmId, message):
Line 328: vm = API.VM(vmId)
Line 329: return vm.desktopSendHcCommand(message)
Line 330:
Line 331: def vmHibernate(self, vmId, target=None):
by the way, is it correct to provide None to vm.hibernate?
Line 332: vm = API.VM(vmId)
Line 333: return vm.hibernate(target)
Line 334:
Line 335: def vmMonitorCommand(self, vmId, cmd):
....................................................
File vdsm_cli/vdsClient.py
Line 61: LEAF_VOL = 8
Line 62:
Line 63: # Guest Hibernate
Line 64: HIBERNATE_TARGET_DISK = "disk"
Line 65: HIBERNATE_TARGET_MEMORY = "mem"
again, is it ok to have it hardcoded, if we have constants?
Line 66: HIBERNATE_TARGET_DEFAULT = HIBERNATE_TARGET_DISK
Line 67:
Line 68:
Line 69: def validateArgTypes(args, conv, requiredArgsNumber=0):
....................................................
File vdsm/vm.py
Line 976: 'sys_shutdown_timeout',
Line 977: self.guestAgent.desktopShutdown, timeout,
Line 978: message)
Line 979:
Line 980: def hibernate(self, target='disk'):
«target: Either HibernateTarget.DISK, HibernateTarget.MEMORY or …»
why here the target default value is hardcoded, not a constant?
Line 981: return self._shutdownCommand('Prepare for hibernate', 0,
Line 982: 'sys_hibernate_timeout',
Line 983: self.guestAgent.hibernate, target)
Line 984:
--
To view, visit
http://gerrit.ovirt.org/1121
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server